Unable to read encrypted file back to an array. I think.

[Tasp]

I've created a personnel management database type program, it's for setting up users and that info will be used as part of another program.
Obviously saving credentials shouldn't be in plain old text format file, so I decided to use Saroussells encryption code to save file.
I first created the main structure and ensured that was functioning ok before adding the encryption portion.
Most encryption code I can find refer to actually reading and writing to files, obviously for password storage keeping anything in a English readable format even briefly is a no no.
So my idea was make into a String$ then, encrypt then save to file and just reverse the process to load in. It's somewhat more complex as its loading from and to an Array$.

And that's where is goes wrong!

I think the issue lies with the [SavePersonnel] branch, as although it saves the info to file, when starting the program for a second time it will only ever show the first record. I thought at first it was an issue with Loading the info in, but it seems (running thru debugger) that once it has decrypted the first record ok, it fails to decrypt the second record. So making the assumption that the issue is something is getting changed/added so it can't decrypt.  I've tried many rewrites including the basics things like adding an extra comma to the end of the save string and adding the <CR> ; from the end of #persfile, Encrypt$; to no avail.

I've spent 2 days just trying to find the issue here!! 



'Encryption Code stolen from Scott A. Rossell :) Thanks sarossell
'https://libertybasiccom.proboards.com/thread/897/simple-uncrackable-encryption-program?page=1

'nomainwin


WindowTitle$ = "Window"

'Create Loading window
WindowWidth = 337 : WindowHeight = 220 : UpperLeftX = INT((DisplayWidth-WindowWidth)/2) : UpperLeftY = INT((DisplayHeight-WindowHeight)/2)
LOADBMP "logo", "Lib\CoreL\Sta.dll"
GRAPHICBOX #graph.box, -3, -3, 337, 250
Open "Opening..." for dialog_popup as #graph
#graph.box, "down ; DRAWBMP logo 0 0 ; UP  ; GOTO 135 170 ; font arial 12 italic"
#graph.box, "\Loading..."

DIM PERSONNEL$(9999,20) 'User details array
DIM info$(0,0)          'fileexists array
DIM List$(9999)         'Listbox array

BackupFileLocation$ = DefaultDir$ + "\Backup\"
currentfilename$ = DefaultDir$ + "personnel2.txt"

GLOBAL RecordNumber, currentfilename$, b, a

Key$ = "1234"   'Define encryption key
b = 0          'Start position number in record, used in Decrypt

randomize(f.SeedCode(Key$))

'Setup main window
WindowWidth = 950 : WindowHeight = 550 : UpperLeftX = INT((DisplayWidth-WindowWidth)/2) : UpperLeftY = INT((DisplayHeight-WindowHeight)/2)

groupbox    #pers.group1, "Personnel Management", 20, 15, 625, 445

statictext  #pers.statictext1,  "Username",     30, 55, 70, 18
statictext  #pers.statictext4,  "Contact",      350, 55, 60, 18
statictext  #pers.statictext2,  "Name",         30, 95, 70, 18
statictext  #pers.statictext3,  "Address",      30, 135, 70, 18
statictext  #pers.statictext5,  "Tel No",       30, 175, 50, 18
statictext  #pers.statictext6,  "Staff No.",    350, 175, 50, 18
statictext  #pers.statictext7,  "Password",     30, 215, 65, 18
statictext  #pers.statictext8,  "Confirm",      350, 215, 65, 18

textbox     #pers.username,    100, 50,  200, 25
textbox     #pers.contact,     420, 50,  200, 25
textbox     #pers.name,        100, 90,  520, 25
textbox     #pers.address,     100, 130, 520, 25
textbox     #pers.telephone,   100, 170, 200, 25
textbox     #pers.staffno,     420, 170, 200, 25
textbox     #pers.pass,        100, 210, 200, 25
textbox     #pers.conf,        420, 210, 200, 25

statictext  #pers.statictext8,  "Detail 1", 30, 255, 70, 18
statictext  #pers.statictext9,  "Detail 2", 30, 295, 70, 18
statictext  #pers.statictext10, "Detail 3", 30, 335, 70, 18
statictext  #pers.statictext11, "Detail 4", 30, 375, 70, 18
statictext  #pers.statictext12, "Detail 5", 30, 415, 70, 18
textbox     #pers.detail1,              100, 250, 370, 25
textbox     #pers.detail2,              100, 290, 370, 25
textbox     #pers.detail3,              100, 330, 370, 25
textbox     #pers.detail4,              100, 370, 370, 25
textbox     #pers.detail5,              100, 410, 370, 25

STYLEBITS   #pers.pass, _ES_PASSWORD, _ES_MULTILINE, 0, 0
STYLEBITS   #pers.conf, _ES_PASSWORD, _ES_MULTILINE, 0, 0

MENU #pers, "Menu", "Clear Fields", ClearScreen, "Search", [Site.Search],|,  "Delete Record", [Delete_Record],|,"Add/Save Record", [Site.Save],|, "Save Changes and Close",[Pers.quit],|, "Close", [quit]

LISTBOX #pers.list, List$(), [ListShowRecord], 675, 21, 230,435

BUTTON       #pers.popup, "Menu", [POPUPMEN], UL, 540, 390, 80, 50
'stylebits   #pers.sitesave, _BS_MULTILINE, 0, 0, 0

statictext  #pers.info, "", 30, 450, 300, 18

Open WindowTitle$ + " - Personnel Management" for Window as #pers
   #pers "trapclose [Pers.Quit.Question]";
   #pers "font trebuchet 10";
   #pers.username, "!setfocus";
   #pers.list, "singleclickselect";

   'Load personnel file, we do this after the window has opened so we can populate the listbox, max is 9999 ppl anyway so it won't take long
   GOSUB [LoadPersonnel]
   CALL UpdateList
   'Close splash screen once everything is loaded and ready.
   CLOSE #graph

[Loop]
   WAIT


[POPUPMEN]
   POPUPMENU "Clear Fields", [ClearScreen], "Search", [Site.Search],|, "Delete Record", [Delete_Record],|, "Add/Save Record", [Site.Save],|, "Save Changes and Close",[Pers.quit],|, "Close", [quit]
   WAIT

[Site.Save]
   #pers.username,     "!contents? Username$"
   #pers.contact,      "!contents? Contact$"
   #pers.name,         "!contents? Name$"
   #pers.address,      "!contents? Address$"
   #pers.telephone,    "!contents? Telephone$"
   #pers.staffno,      "!contents? Staffno$"
   #pers.pass,         "!contents? pass$"
   #pers.conf,         "!contents? conf$"
   #pers.detail1,      "!contents? Site.Detail1$"
   #pers.detail2,      "!contents? Site.Detail2$"
   #pers.detail3,      "!contents? Site.Detail3$"
   #pers.detail4,      "!contents? Site.Detail4$"
   #pers.detail5,      "!contents? Site.Detail5$"

   'Check to see if user has used commas in the fields. They can't because we used CSV files!
   CALL CheckCommas Username$
   CALL CheckCommas Name$
   CALL CheckCommas Address$
   CALL CheckCommas Contact$
   CALL CheckCommas Telephone$
   CALL CheckCommas Staffno$
   CALL CheckCommas pass$
   CALL CheckCommas conf$
   CALL CheckCommas Site.Detail1$
   CALL CheckCommas Site.Det7ail2$
   CALL CheckCommas Site.Detail3$
   CALL CheckCommas Site.Detail4$
   CALL CheckCommas Site.Detail5$

   'Check Password matches with confirmation
   IF pass$ = "" OR conf$ = "" THEN NOTICE WindowTitle$ + " - Warning!" + chr$(13) +  "Password cannot be blank" : WAIT

   IF pass$ = conf$ THEN
      pass = 1
   ELSE
      NOTICE WindowTitle$ + " - Warning!" + chr$(13) +  "Passwords don't match!"
      pass = 0
      WAIT
   END IF

   'WRITE / Update SITES array
   FOR a = 0 TO RecordNumber
   #pers.info "Checking for duplicate usernames "; a
       TempPersno$ = PERSONNEL$(a, 1)
       #pers.info "Checking if "; TempPersno$ ; " = " ; Username$
       IF TempPersno$ = Username$ THEN
           OverwriteFlag = 1
           calldll #user32, "MessageBeep", _MB_ICONQUESTION  as long, beepResult as boolean
           mbflags = _MB_ICONQUESTION OR _MB_YESNO
           calldll #user32, "MessageBoxA", 0 as long, "A record already exists with this username. Do you wish to overwrite?" as ptr, WindowTitle$ as ptr, mbflags as long, mbResult as long
           'mbResult CODES: 1=ok 2=cancel 3=abort 4=retry 5=ignore 6=yes 7=no
           IF mbResult = 6 THEN EXIT FOR
           IF mbResult = 7 THEN WAIT
       END IF
   NEXT

   IF OverwriteFlag = 1 THEN
       #pers.info "Username already used, overwriting, " ; a
       PERSONNEL$(a,1) = Username$
       PERSONNEL$(a,2) = Contact$
       PERSONNEL$(a,3) = Name$
       PERSONNEL$(a,4) = Address$
       PERSONNEL$(a,5) = Telephone$
       PERSONNEL$(a,6) = Staffno$
       PERSONNEL$(a,7) = pass$
       PERSONNEL$(a,8) = Site.Detail1$
       PERSONNEL$(a,9) = Site.Detail2$
       PERSONNEL$(a,10) = Site.Detail3$
       PERSONNEL$(a,11) = Site.Detail4$
       PERSONNEL$(a,12) = Site.Detail5$
       PERSONNEL$(a,13) = Opncls$
       PERSONNEL$(a,14) = mapuse$
   ELSE
       #pers.info "Saving new record ";RecordNumber
       PERSONNEL$(RecordNumber,1) = Username$
       PERSONNEL$(RecordNumber,2) = Contact$
       PERSONNEL$(RecordNumber,3) = Name$
       PERSONNEL$(RecordNumber,4) = Address$
       PERSONNEL$(RecordNumber,5) = Telephone$
       PERSONNEL$(RecordNumber,6) = Staffno$
       PERSONNEL$(RecordNumber,7) = pass$
       PERSONNEL$(RecordNumber,8) = Site.Detail1$
       PERSONNEL$(RecordNumber,9) = Site.Detail2$
       PERSONNEL$(RecordNumber,10) = Site.Detail3$
       PERSONNEL$(RecordNumber,11) = Site.Detail4$
       PERSONNEL$(RecordNumber,12) = Site.Detail5$
       PERSONNEL$(RecordNumber,13) = Opncls$
       PERSONNEL$(RecordNumber,14) = mapuse$
       RecordNumber = RecordNumber + 1
   END IF

   OverwriteFlag = 0

   NOTICE WindowTitle$ + chr$(13) + "Record added successfully."

   CALL ClearScreen
   CALL UpdateList
   WAIT

[Delete_Record] 'Delete current record and move everything back 1 record
   #pers.username, "!contents? Delinfo$"
   IF Delinfo$ = "" THEN NOTICE WindowTitle$ + " - Warning!" + chr$(13) +  "Username cannot be blank." : WAIT

   FOR a = sRecord TO (RecordNumber)
       b = a + 1
       PERSONNEL$(a,1) = PERSONNEL$(b,1)
       PERSONNEL$(a,2) = PERSONNEL$(b,2)
       PERSONNEL$(a,3) = PERSONNEL$(b,3)
       PERSONNEL$(a,4) = PERSONNEL$(b,4)
       PERSONNEL$(a,5) = PERSONNEL$(b,5)
       PERSONNEL$(a,6) = PERSONNEL$(b,6)
       PERSONNEL$(a,7) = PERSONNEL$(b,7)
       PERSONNEL$(a,8) = PERSONNEL$(b,8)
       PERSONNEL$(a,9) = PERSONNEL$(b,9)
       PERSONNEL$(a,10) = PERSONNEL$(b,10)
       PERSONNEL$(a,11) = PERSONNEL$(b,11)
       PERSONNEL$(a,12) = PERSONNEL$(b,12)
       PERSONNEL$(a,13) = PERSONNEL$(b,13)
       PERSONNEL$(a,14) = PERSONNEL$(b,14)

   NEXT

   NOTICE WindowTitle$ + chr$(13) + "Record deleted successfully."

   CALL ClearScreen
   CALL UpdateList

   WAIT

[Site.Search] 'Perform search
   SearchFound = 0
   #pers.username,     "!contents? Username$"
   #pers.contact,      "!contents? Contact$"
   #pers.name,         "!contents? Name$"
   #pers.address,      "!contents? Address$"
   #pers.telephone,    "!contents? Telephone$"
   #pers.staffno,      "!contents? Staffno$"
   #pers.pass,         "!contents? pass$"
   #pers.conf,         "!contents? conf$"
   #pers.detail1,      "!contents? Site.Detail1$"
   #pers.detail2,      "!contents? Site.Detail2$"
   #pers.detail3,      "!contents? Site.Detail3$"
   #pers.detail4,      "!contents? Site.Detail4$"
   #pers.detail5,      "!contents? Site.Detail5$"

   FOR sRecord = 0 TO RecordNumber
   #pers.info, "SEARCHING...." ;a
           IF s.Username$ =                              PERSONNEL$(sRecord, 1)                    THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Name$ <> ""        AND LOWER$(s.Name$) = LOWER$(PERSONNEL$(sRecord, 2))       THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Address$ <> ""     AND LOWER$(s.Address$) = LOWER$(PERSONNEL$(sRecord, 3))    THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Contactname$ <> "" AND LOWER$(s.Contactname$) = LOWER$(PERSONNEL$(sRecord, 4))THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Telephone$ <> ""   AND s.Telephone$ = PERSONNEL$(sRecord, 5)                  THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Staffno$ <> ""       AND s.Staffno$ = PERSONNEL$(sRecord, 6)                      THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
'        END IF
   NEXT

   'If record is found, do something here. Populate fields etc
   IF SearchFound = 1 THEN

       #pers.info,"Found Record: "; sRecord
       #pers.username,  PERSONNEL$(sRecord, 1)
       #pers.contact,   PERSONNEL$(sRecord, 2)
       #pers.name,      PERSONNEL$(sRecord, 3)
       #pers.address,   PERSONNEL$(sRecord, 4)
       #pers.telephone, PERSONNEL$(sRecord, 5)
       #pers.staffno,   PERSONNEL$(sRecord, 6)
       #pers.detail1,   PERSONNEL$(sRecord, 8)
       #pers.detail2,   PERSONNEL$(sRecord, 9)
       #pers.detail3,   PERSONNEL$(sRecord, 10)
       #pers.detail4,   PERSONNEL$(sRecord, 11)
       #pers.detail5,   PERSONNEL$(sRecord, 12)

   END IF

   PRINT "Search DONE!"

   IF SearchFound = 0 THEN #pers.info, "Complete."
WAIT

[SavePersonnel]
   #pers.info "Saving site info. Total Records:"; RecordNumber
   LOADBMP "logo", "Lib\CoreL\Sta.dll"
   WindowWidth = 337 : WindowHeight = 220 : UpperLeftX = INT((DisplayWidth-WindowWidth)/2) : UpperLeftY = INT((DisplayHeight-WindowHeight)/2)
   GRAPHICBOX #graph.box, -3, -3, 337, 250
   Open "Saving..." for dialog_popup as #graph
   #graph.box, "down ; DRAWBMP logo 0 0 ; UP  ; GOTO 135 170 ; font arial 12 italic"
   #graph.box, "\Saving..."

   CALL DisableScreen

   OPEN currentfilename$ for BINARY as #persfile

   FOR index = 0 TO RecordNumber
   #pers.info, "Saving "; index
   PRINT "Saving "; index
       IF PERSONNEL$(index,1) <> "" THEN
           #pers.info, "Saving index:"; index ; " Pers: " ; PERSONNEL$(index,1)
           PRINT "Saving index:"; index ; " Pers: " ; PERSONNEL$(index,1)
           Username$ =         PERSONNEL$(index,1)
           Name$ =        PERSONNEL$(index,2)
           Address$ =     PERSONNEL$(index,3)
           Contactname$ = PERSONNEL$(index,4)
           Telephone$ =   PERSONNEL$(index,5)
           Keyno$ =       PERSONNEL$(index,6)
           RemoteIP$ =    PERSONNEL$(index,7)
           Site.Detail1$ =     PERSONNEL$(index,8)
           Site.Detail2$ =     PERSONNEL$(index,9)
           Site.Detail3$ =     PERSONNEL$(index,10)
           Site.Detail4$ =     PERSONNEL$(index,11)
           Site.Detail5$ =     PERSONNEL$(index,12)
           Opncls$ =           PERSONNEL$(index,13)
           mapuse$ =           PERSONNEL$(index,14)

           PersData$ = Username$ + "," + Name$ + "," + Address$ + "," + Contactname$ + "," + Telephone$ + "," + Keyno$ + "," + RemoteIP$ + "," + Site.Detail1$ + "," + Site.Detail2$ + "," + Site.Detail3$ + "," + Site.Detail4$ + "," + Site.Detail5$ + "," + Opncls$ + "," + mapuse$  + ","
           '#persfile, PersData$
           FOR v.Cnt1 = 1 TO LEN(PersData$)
               PRINT "PersData$: "; PersData$
               Encrypt$ = Encrypt$ + chr$(asc(MID$(PersData$,v.Cnt1)) XOR int(rnd(1)*256))
           NEXT
           print "Encrypt: "; Encrypt$
           #persfile, Encrypt$;
       END IF
   NEXT

   CLOSE #persfile
   CALL ClearScreen
   CLOSE #graph

   CALL EnableScreen
'END SUB
RETURN

[LoadPersonnel]
   If fileExists(DefaultDir$, "Lib\CoreL\personnel.lor") < 1 then
       NOTICE WindowTitle$ + chr$(13) + "Database file does not exist or cannot be found."
       CLOSE #graph
       CLOSE #pers
       END
   End IF


   OPEN currentfilename$ for BINARY as #InFile
trace 3
       FOR v.Cnt1 = 1 TO lof(#InFile)
           Decrypt$ = chr$(asc(input$(#InFile,1)) XOR int(rnd(1)*256))
           Built$ = Built$ + Decrypt$
           'Fill array, moving one record each comma
           IF Decrypt$ = "," THEN
               Built$ = remchar$(Built$, ",")
               PERSONNEL$(a, b) = Built$
               PRINT "Built$ = "; Built$; " a = ";a;" b = ";b
               b = b + 1 : Built$ = ""
           END IF

           'We know the file structure has 14 commas so when we hit 14 we can move to the next record position otherwise we keep filling the same position
'            IF Decrypt$ = CHR$(10) THEN
           IF b = 15 THEN
               a = a + 1
               b = 1
               RecordNumber = RecordNumber + 1
           END IF
       NEXT
   CLOSE #InFile
   CALL UpdateList
RETURN

[ListShowRecord]
   #pers.list,  "selection? s.Username$"
   FOR sRecord = 0 TO RecordNumber
   #pers.info, "SEARCHING...." ;a
           IF s.Username$ =                              PERSONNEL$(sRecord, 1)                THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Name$ <> ""        AND LOWER$(s.Name$) = LOWER$(PERSONNEL$(sRecord, 2))        THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Address$ <> ""     AND LOWER$(s.Address$) = LOWER$(PERSONNEL$(sRecord, 3))     THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Contactname$ <> "" AND LOWER$(s.Contactname$) = LOWER$(PERSONNEL$(sRecord, 4)) THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Telephone$ <> ""   AND s.Telephone$ = PERSONNEL$(sRecord, 5)                   THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Staffno$ <> ""     AND s.Staffno$ = PERSONNEL$(sRecord, 6)                     THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
'        END IF
   NEXT

   'If record is found, do something here. Populate fields etc
   IF SearchFound = 1 THEN

       #pers.info,"Found Record: "; sRecord
       #pers.username,   PERSONNEL$(sRecord, 1)
       #pers.contact,    PERSONNEL$(sRecord, 2)
       #pers.name,       PERSONNEL$(sRecord, 3)
       #pers.address,    PERSONNEL$(sRecord, 4)
       #pers.telephone,  PERSONNEL$(sRecord, 5)
       #pers.staffno,    PERSONNEL$(sRecord, 6)
       #pers.detail1,    PERSONNEL$(sRecord, 8)
       #pers.detail2,    PERSONNEL$(sRecord, 9)
       #pers.detail3,    PERSONNEL$(sRecord, 10)
       #pers.detail4,    PERSONNEL$(sRecord, 11)
       #pers.detail5,    PERSONNEL$(sRecord, 12)

   END IF

   PRINT "ListShowRecord. sRecord:";sRecord;" RecordNumber: "; RecordNumber

   IF SearchFound = 0 THEN #pers.info, "Complete."
WAIT

[Pers.Quit.Question]
   NOTICE WindowTitle$ + chr$(13) + "Please use the Menu to [Save all Records and Close] or [Close] without saving."
   WAIT

[Pers.quit]
   GOSUB [SavePersonnel]
   CLOSE #pers
   UNLOADBMP "logo"
   END

[quit]
   CLOSE #pers
   UNLOADBMP "logo"
   END

[ClearScreen]
   CALL ClearScreen
WAIT

SUB UpdateList
   FOR c = 0 TO RecordNumber
   PRINT "Update Listbox: "; PERSONNEL$(c, 1); " Total Records: "; RecordNumber
   List$(c) = PERSONNEL$(c, 1)
   NEXT
   #pers.list, "reload"
END SUB

'Remove commas
SUB CheckCommas BYREF StringName$
   'print "checking for commas!"
   StringName$ = remchar$(StringName$, ",")
END SUB

'Function to determine if a file exists
FUNCTION fileExists(path$, filename$)
   FILES path$, filename$, info$()
   fileExists = val(info$(0, 0))  'non zero is true
END FUNCTION

FUNCTION f.SeedCode(in.STG$)
   ' Uses the DLL to generate a CSC-32 hash of the input string. 'Remove commas
   v.StringLen = len(in.STG$)
   OPEN "ntdll.dll" FOR dll AS #ntdll
   CALLDLL #ntdll, "RtlComputeCrc32", 0 as long, in.STG$ as ptr, v.StringLen as long, result as long
   CLOSE #ntdll
   ' CSC-32 hash is turned into a decimal value.
   f.SeedCode = val("." + str$(abs(result)))
END FUNCTION

SUB DisableScreen
   #pers.username,     "!DISABLE"
   #pers.contact,      "!DISABLE"
   #pers.name,         "!DISABLE"
   #pers.address,      "!DISABLE"
   #pers.telephone,    "!DISABLE"
   #pers.staffno,      "!DISABLE"
   #pers.pass,         "!DISABLE"
   #pers.conf,         "!DISABLE"
   #pers.detail1,      "!DISABLE"
   #pers.detail2,      "!DISABLE"
   #pers.detail3,      "!DISABLE"
   #pers.detail4,      "!DISABLE"
   #pers.detail5,      "!DISABLE"
END SUB

SUB EnableScreen
   #pers.username,     "!ENABLE"
   #pers.contact,      "!ENABLE"
   #pers.name,         "!ENABLE"
   #pers.address,      "!ENABLE"
   #pers.telephone,    "!ENABLE"
   #pers.staffno,      "!ENABLE"
   #pers.pass,         "!ENABLE"
   #pers.conf,         "!ENABLE"
   #pers.detail1,      "!ENABLE"
   #pers.detail2,      "!ENABLE"
   #pers.detail3,      "!ENABLE"
   #pers.detail4,      "!ENABLE"
   #pers.detail5,      "!ENABLE"
END SUB

SUB ClearScreen
   #pers.username,     ""
   #pers.contact,      ""
   #pers.name,         ""
   #pers.address,      ""
   #pers.telephone,    ""
   #pers.staffno,      ""
   #pers.pass,         ""
   #pers.conf,         ""
   #pers.detail1,      ""
   #pers.detail2,      ""
   #pers.detail3,      ""
   #pers.detail4,      ""
   #pers.detail5,      ""

   Username$ = ""
   Contact$ = ""
   Name$ = ""
   Address$ = ""
   Telephone$ = ""
   Staffno$ = ""
   pass$ = ""
   conf$ = ""
   Site.Detail1$ = ""
   Site.Detail2$ = ""
   Site.Detail3$ = ""
   Site.Detail4$ = ""
   Site.Detail5$ = ""
   #pers.info, "Ready."
END SUB


*Username, password and confirm are mandatory fields.

TIA

EDIT: I've just found David Drakes implementation of a basic cypher LINK and wonder if this would be better suited?

[Rod]

Does it run correctly in clear? without encryption? If this is a corporate environment perhaps there is no need to encrypt contact data, perhaps just the password needs encrypted? even here perhaps you only need a password stylebits on the inputbox?

[Tasp]

If I comment out the encryption side of things it works fine.

It's not going into a corporate environment no, but it will need to ensure that a user cannot change others details, plus if it is ever deployed into a commercial environment, if somebody is able to see others details, could that be a GDPR breach.
Besides, encrypting just the password would probably cause just as many issues for me, as I would be getting personal info from one place and the passwords from a different file.

[Chris Iverson]

One thing I would check would be to make sure the random numbers are coming out the same. I don't see why they wouldn't be, especially considering the first record gets decrypted, but it couldn't hurt to check.

Modify the code so that the random number that the character gets XOR'd with gets stored to a variable first, and print out that variable. Make sure that the list of numbers matches for both saving the file and loading it.

That is, instead of:

Encrypt$ = Encrypt$ + chr$(asc(MID$(PersData$,v.Cnt1)) XOR int(rnd(1)*256))

do:

randNum = int(rnd(1)*256))
print randNum
Encrypt$ = Encrypt$ + chr$(asc(MID$(PersData$,v.Cnt1)) XOR randNum

And do the same for decryption.


If the numbers differ, then something's screwing up the randomizer. If the numbers don't differ, then there's somehow a data difference somewhere.

[tsh73]

I've spent 2 days just trying to find the issue here!!

You obviously spent some time preventing anyone to help you.

Hoops to jump through to run this program:
1)create subdirectory
lib\CoreL
2) create file
lib\CoreL\personnel.lor
3) put random bitmap to
lib\CoreL
and rename it to
Sta.dll

Now I try to find there it actually stores data
currentfilename$ = DefaultDir$ + "personnel2.txt"
Isn't that nice? It results in
C:\Program Files\Liberty BASIC v4.5.1personnel2.txt
Hard to find, really

It happens to be easy after all
There are more then I saw first time, and it does take time to look into.

Then you do encrypt, you
1) save 1st encrypted record
2) keep adding second record to first
3) save 1st encrypted record + 2nd encrypted record
4) keep adding third record to (first+second)
5) save 1st encrypted record + 2nd encrypted record + 3rd encrypted record
You get the idea.

The thing you need to add is
Encrypt$=""
just after
#persfile, Encrypt$;

Besides
after reading file, RecordNumber is one less - Add
RecordNumber = RecordNumber + 1
after
CLOSE #InFile

Besides
you really should reset random number before save and before load
(or then you load and then save, encription starts from new position then creating from scratch)
I think just after opening file will be right.
(that's actually what Chris guessed)

ALSO
it happens to be error then reading data
all records starts with b = 1
but first one starts with 0
So it loses first fields, and all others move one field up
(to find this I finally disabled encryption)
It could be fixed by adding
b = 1
before
       FOR v.Cnt1 = 1 TO lof(#InFile)

Ok I hope this will help you a bit.

[Tasp]

Firstly let me apologise, I should have commented out the code for the loading screen etc, it was an oversight and I normally remove those kinda things before posting, however I was so frustrated with everything I overlooked this.

Secondly, I removed the folder structure so people could actually test!! And I forgot to remove the check for file existence as well!!

currentfilename$ = DefaultDir$ + "personnel2.txt"

I appreciate if you want help people need to be able to copy and paste your code, not mess around with bmp/file structures etc.  Sorry all (2/10 must try harder next time!).

Anyway back to LB


Posted by Chris Iverson 13 hours ago

One thing I would check would be to make sure the random numbers are coming out the same. I don't see why they wouldn't be, especially considering the first record gets decrypted, but it couldn't hurt to check.
Modify the code so that the random number that the character gets XOR'd with gets stored to a variable first, and print out that variable. Make sure that the list of numbers matches for both saving the file and loading it.
That is, instead of:

Encrypt$ = Encrypt$ + chr$(asc(MID$(PersData$,v.Cnt1)) XOR int(rnd(1)*256))


I did already think this could be an issue so I moved the function to get the random number to the start rather than in each load/save branch, in case it was generating a new number each time. But one thing I don't understand is, in sarossell original code there's a function that is called and seemingly gets a randomized number, yet I don't see that actually being used in the encryption code. This part;


randomize(f.SeedCode(Key$))

'and it's function
FUNCTION f.SeedCode(in.STG$)
   ' Uses the DLL to generate a CSC-32 hash of the input string. 'Remove commas
   v.StringLen = len(in.STG$)
   OPEN "ntdll.dll" FOR dll AS #ntdll
   CALLDLL #ntdll, "RtlComputeCrc32", 0 as long, in.STG$ as ptr, v.StringLen as long, result as long
   CLOSE #ntdll
   ' CSC-32 hash is turned into a decimal value.
   f.SeedCode = val("." + str$(abs(result)))
END FUNCTION

When the actual random number is


int(rnd(1)*256))

Or am I missing the point?

---

So to get this working I did a few things.

Read everyone's post 6 times.

Then added this to the Load/Save branches. Don't know if it does anything but the suggestion made sense to me, kinda.


randomize(f.SeedCode(Key$))


Cleared the Encrypt$ within the Save branch. Which I think may have been my biggest issue. And which is probably why it ran ok for me in the clear.

Added an extra comma to the end of the PersData$ when concatenating so that the CSV mechanism actually catches the first position of the 2nd record correctly.

This code, I think, is actually working now. I've commented out all the things that should stop you from just copying, pasting and running. It should create a file named personnel.txt automagically.


'Encryption Code stolen from Scott A. Rossell :) Thanks sarossell
'https://libertybasiccom.proboards.com/thread/897/simple-uncrackable-encryption-program?page=1
'With assistance from Rod, Chris Iverson and tsh73
'https://libertybasiccom.proboards.com/thread/1396/unable-read-encrypted-file-array

'nomainwin


WindowTitle$ = "Window"


DIM PERSONNEL$(9999,20) 'User details array
DIM info$(0,0)          'fileexists array
DIM List$(9999)         'Listbox array

BackupFileLocation$ = DefaultDir$ + "\Backup\"
currentfilename$ = DefaultDir$ + "\personnel.txt"

GLOBAL RecordNumber, currentfilename$, b, a

Key$ = "1234"   'Define encryption key
b = 1           'Start position number in record, used in Decrypt


'Setup main window
WindowWidth = 950 : WindowHeight = 550 : UpperLeftX = INT((DisplayWidth-WindowWidth)/2) : UpperLeftY = INT((DisplayHeight-WindowHeight)/2)

groupbox    #pers.group1, "Personnel Management", 20, 15, 625, 445

statictext  #pers.statictext1,  "Username",     30, 55, 70, 18
statictext  #pers.statictext4,  "Contact",      350, 55, 60, 18
statictext  #pers.statictext2,  "Name",         30, 95, 70, 18
statictext  #pers.statictext3,  "Address",      30, 135, 70, 18
statictext  #pers.statictext5,  "Tel No",       30, 175, 50, 18
statictext  #pers.statictext6,  "Staff No.",    350, 175, 50, 18
statictext  #pers.statictext7,  "Password",     30, 215, 65, 18
statictext  #pers.statictext8,  "Confirm",      350, 215, 65, 18

textbox     #pers.username,    100, 50,  200, 25
textbox     #pers.contact,     420, 50,  200, 25
textbox     #pers.name,        100, 90,  520, 25
textbox     #pers.address,     100, 130, 520, 25
textbox     #pers.telephone,   100, 170, 200, 25
textbox     #pers.staffno,     420, 170, 200, 25
textbox     #pers.pass,        100, 210, 200, 25
textbox     #pers.conf,        420, 210, 200, 25

statictext  #pers.statictext8,  "Detail 1", 30, 255, 70, 18
statictext  #pers.statictext9,  "Detail 2", 30, 295, 70, 18
statictext  #pers.statictext10, "Detail 3", 30, 335, 70, 18
statictext  #pers.statictext11, "Detail 4", 30, 375, 70, 18
statictext  #pers.statictext12, "Detail 5", 30, 415, 70, 18
textbox     #pers.detail1,              100, 250, 370, 25
textbox     #pers.detail2,              100, 290, 370, 25
textbox     #pers.detail3,              100, 330, 370, 25
textbox     #pers.detail4,              100, 370, 370, 25
textbox     #pers.detail5,              100, 410, 370, 25

STYLEBITS   #pers.pass, _ES_PASSWORD, _ES_MULTILINE, 0, 0
STYLEBITS   #pers.conf, _ES_PASSWORD, _ES_MULTILINE, 0, 0

MENU #pers, "Menu", "Clear Fields", ClearScreen, "Search", [Site.Search],|,  "Delete Record", [Delete_Record],|,"Add/Save Record", [Site.Save],|, "Save Changes and Close",[Pers.quit],|, "Close", [quit]

LISTBOX #pers.list, List$(), [ListShowRecord], 675, 21, 230,435

BUTTON       #pers.popup, "Menu", [POPUPMEN], UL, 540, 390, 80, 50
'stylebits   #pers.sitesave, _BS_MULTILINE, 0, 0, 0

statictext  #pers.info, "", 30, 450, 300, 18

Open WindowTitle$ + " - Personnel Management" for Window as #pers
   #pers "trapclose [Pers.Quit.Question]";
   #pers "font trebuchet 10";
   #pers.username, "!setfocus";
   #pers.list, "singleclickselect";

   'Load personnel file, we do this after the window has opened so we can populate the listbox, max is 9999 ppl anyway so it won't take long
   GOSUB [LoadPersonnel]
   CALL UpdateList
   'Close splash screen once everything is loaded and ready.
'    CLOSE #graph

[Loop]
   WAIT


[POPUPMEN]
   POPUPMENU "Clear Fields", [ClearScreen], "Search", [Site.Search],|, "Delete Record", [Delete_Record],|, "Add/Save Record", [Site.Save],|, "Save Changes and Close",[Pers.quit],|, "Close", [quit]
   WAIT

[Site.Save]
   #pers.username,     "!contents? Username$"
   #pers.contact,      "!contents? Contact$"
   #pers.name,         "!contents? Name$"
   #pers.address,      "!contents? Address$"
   #pers.telephone,    "!contents? Telephone$"
   #pers.staffno,      "!contents? Staffno$"
   #pers.pass,         "!contents? pass$"
   #pers.conf,         "!contents? conf$"
   #pers.detail1,      "!contents? Site.Detail1$"
   #pers.detail2,      "!contents? Site.Detail2$"
   #pers.detail3,      "!contents? Site.Detail3$"
   #pers.detail4,      "!contents? Site.Detail4$"
   #pers.detail5,      "!contents? Site.Detail5$"

   'Check to see if user has used commas in the fields. They can't because we used CSV files!
   CALL CheckCommas Username$
   CALL CheckCommas Name$
   CALL CheckCommas Address$
   CALL CheckCommas Contact$
   CALL CheckCommas Telephone$
   CALL CheckCommas Staffno$
   CALL CheckCommas pass$
   CALL CheckCommas conf$
   CALL CheckCommas Site.Detail1$
   CALL CheckCommas Site.Det7ail2$
   CALL CheckCommas Site.Detail3$
   CALL CheckCommas Site.Detail4$
   CALL CheckCommas Site.Detail5$

   'Check Password matches with confirmation
   IF pass$ = "" OR conf$ = "" THEN NOTICE WindowTitle$ + " - Warning!" + chr$(13) +  "Password cannot be blank" : WAIT

   IF pass$ = conf$ THEN
      pass = 1
   ELSE
      NOTICE WindowTitle$ + " - Warning!" + chr$(13) +  "Passwords don't match!"
      pass = 0
      WAIT
   END IF

   'WRITE / Update SITES array
   FOR a = 0 TO RecordNumber
   #pers.info "Checking for duplicate usernames "; a
       TempPersno$ = PERSONNEL$(a, 1)
       #pers.info "Checking if "; TempPersno$ ; " = " ; Username$
       IF TempPersno$ = Username$ THEN
           OverwriteFlag = 1
           calldll #user32, "MessageBeep", _MB_ICONQUESTION  as long, beepResult as boolean
           mbflags = _MB_ICONQUESTION OR _MB_YESNO
           calldll #user32, "MessageBoxA", 0 as long, "A record already exists with this username. Do you wish to overwrite?" as ptr, WindowTitle$ as ptr, mbflags as long, mbResult as long
           'mbResult CODES: 1=ok 2=cancel 3=abort 4=retry 5=ignore 6=yes 7=no
           IF mbResult = 6 THEN EXIT FOR
           IF mbResult = 7 THEN WAIT
       END IF
   NEXT

   IF OverwriteFlag = 1 THEN
       #pers.info "Username already used, overwriting, " ; a
       PERSONNEL$(a,1) = Username$
       PERSONNEL$(a,2) = Contact$
       PERSONNEL$(a,3) = Name$
       PERSONNEL$(a,4) = Address$
       PERSONNEL$(a,5) = Telephone$
       PERSONNEL$(a,6) = Staffno$
       PERSONNEL$(a,7) = pass$
       PERSONNEL$(a,8) = Site.Detail1$
       PERSONNEL$(a,9) = Site.Detail2$
       PERSONNEL$(a,10) = Site.Detail3$
       PERSONNEL$(a,11) = Site.Detail4$
       PERSONNEL$(a,12) = Site.Detail5$
       PERSONNEL$(a,13) = Opncls$
       PERSONNEL$(a,14) = mapuse$
   ELSE
       #pers.info "Saving new record ";RecordNumber
       PERSONNEL$(RecordNumber,1) = Username$
       PERSONNEL$(RecordNumber,2) = Contact$
       PERSONNEL$(RecordNumber,3) = Name$
       PERSONNEL$(RecordNumber,4) = Address$
       PERSONNEL$(RecordNumber,5) = Telephone$
       PERSONNEL$(RecordNumber,6) = Staffno$
       PERSONNEL$(RecordNumber,7) = pass$
       PERSONNEL$(RecordNumber,8) = Site.Detail1$
       PERSONNEL$(RecordNumber,9) = Site.Detail2$
       PERSONNEL$(RecordNumber,10) = Site.Detail3$
       PERSONNEL$(RecordNumber,11) = Site.Detail4$
       PERSONNEL$(RecordNumber,12) = Site.Detail5$
       PERSONNEL$(RecordNumber,13) = Opncls$
       PERSONNEL$(RecordNumber,14) = mapuse$
       RecordNumber = RecordNumber + 1
   END IF

   OverwriteFlag = 0

   NOTICE WindowTitle$ + chr$(13) + "Record added successfully."

   CALL ClearScreen
   CALL UpdateList
   WAIT

[Delete_Record] 'Delete current record and move everything back 1 record
   #pers.username, "!contents? Delinfo$"
   IF Delinfo$ = "" THEN NOTICE WindowTitle$ + " - Warning!" + chr$(13) +  "Username cannot be blank." : WAIT

   FOR a = sRecord TO (RecordNumber)
       b = a + 1
       PERSONNEL$(a,1) = PERSONNEL$(b,1)
       PERSONNEL$(a,2) = PERSONNEL$(b,2)
       PERSONNEL$(a,3) = PERSONNEL$(b,3)
       PERSONNEL$(a,4) = PERSONNEL$(b,4)
       PERSONNEL$(a,5) = PERSONNEL$(b,5)
       PERSONNEL$(a,6) = PERSONNEL$(b,6)
       PERSONNEL$(a,7) = PERSONNEL$(b,7)
       PERSONNEL$(a,8) = PERSONNEL$(b,8)
       PERSONNEL$(a,9) = PERSONNEL$(b,9)
       PERSONNEL$(a,10) = PERSONNEL$(b,10)
       PERSONNEL$(a,11) = PERSONNEL$(b,11)
       PERSONNEL$(a,12) = PERSONNEL$(b,12)
       PERSONNEL$(a,13) = PERSONNEL$(b,13)
       PERSONNEL$(a,14) = PERSONNEL$(b,14)

   NEXT

   NOTICE WindowTitle$ + chr$(13) + "Record deleted successfully."

   CALL ClearScreen
   CALL UpdateList

   WAIT

[Site.Search] 'Perform search
   SearchFound = 0
   #pers.username,     "!contents? Username$"
   #pers.contact,      "!contents? Contact$"
   #pers.name,         "!contents? Name$"
   #pers.address,      "!contents? Address$"
   #pers.telephone,    "!contents? Telephone$"
   #pers.staffno,      "!contents? Staffno$"
   #pers.pass,         "!contents? pass$"
   #pers.conf,         "!contents? conf$"
   #pers.detail1,      "!contents? Site.Detail1$"
   #pers.detail2,      "!contents? Site.Detail2$"
   #pers.detail3,      "!contents? Site.Detail3$"
   #pers.detail4,      "!contents? Site.Detail4$"
   #pers.detail5,      "!contents? Site.Detail5$"

   FOR sRecord = 0 TO RecordNumber
   #pers.info, "SEARCHING...." ;a
           IF s.Username$ =                              PERSONNEL$(sRecord, 1)                    THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Name$ <> ""        AND LOWER$(s.Name$) = LOWER$(PERSONNEL$(sRecord, 2))       THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Address$ <> ""     AND LOWER$(s.Address$) = LOWER$(PERSONNEL$(sRecord, 3))    THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Contactname$ <> "" AND LOWER$(s.Contactname$) = LOWER$(PERSONNEL$(sRecord, 4))THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Telephone$ <> ""   AND s.Telephone$ = PERSONNEL$(sRecord, 5)                  THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Staffno$ <> ""       AND s.Staffno$ = PERSONNEL$(sRecord, 6)                      THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
'        END IF
   NEXT

   'If record is found, do something here. Populate fields etc
   IF SearchFound = 1 THEN

       #pers.info,"Found Record: "; sRecord
       #pers.username,  PERSONNEL$(sRecord, 1)
       #pers.contact,   PERSONNEL$(sRecord, 2)
       #pers.name,      PERSONNEL$(sRecord, 3)
       #pers.address,   PERSONNEL$(sRecord, 4)
       #pers.telephone, PERSONNEL$(sRecord, 5)
       #pers.staffno,   PERSONNEL$(sRecord, 6)
       #pers.detail1,   PERSONNEL$(sRecord, 8)
       #pers.detail2,   PERSONNEL$(sRecord, 9)
       #pers.detail3,   PERSONNEL$(sRecord, 10)
       #pers.detail4,   PERSONNEL$(sRecord, 11)
       #pers.detail5,   PERSONNEL$(sRecord, 12)

   END IF

   PRINT "Search DONE!"

   IF SearchFound = 0 THEN #pers.info, "Complete."
WAIT

[SavePersonnel]
   randomize(f.SeedCode(Key$))
   #pers.info "Saving site info. Total Records:"; RecordNumber
   'LOADBMP "logo", "Lib\CoreL\Sta.dll"
   'WindowWidth = 337 : WindowHeight = 220 : UpperLeftX = INT((DisplayWidth-WindowWidth)/2) : UpperLeftY = INT((DisplayHeight-WindowHeight)/2)
   'GRAPHICBOX #graph.box, -3, -3, 337, 250
   'Open "Saving..." for dialog_popup as #graph
   '#graph.box, "down ; DRAWBMP logo 0 0 ; UP  ; GOTO 135 170 ; font arial 12 italic"
   '#graph.box, "\Saving..."

   CALL DisableScreen

   OPEN currentfilename$ for BINARY as #persfile

   FOR index = 0 TO RecordNumber
   #pers.info, "Saving "; index
   PRINT "Saving "; index
       IF PERSONNEL$(index,1) <> "" THEN
           #pers.info, "Saving index:"; index ; " Pers: " ; PERSONNEL$(index,1)
           PRINT "Saving index:"; index ; " Pers: " ; PERSONNEL$(index,1)
           Username$ =         PERSONNEL$(index,1)
           Name$ =        PERSONNEL$(index,2)
           Address$ =     PERSONNEL$(index,3)
           Contactname$ = PERSONNEL$(index,4)
           Telephone$ =   PERSONNEL$(index,5)
           Keyno$ =       PERSONNEL$(index,6)
           RemoteIP$ =    PERSONNEL$(index,7)
           Site.Detail1$ =     PERSONNEL$(index,8)
           Site.Detail2$ =     PERSONNEL$(index,9)
           Site.Detail3$ =     PERSONNEL$(index,10)
           Site.Detail4$ =     PERSONNEL$(index,11)
           Site.Detail5$ =     PERSONNEL$(index,12)
           Opncls$ =           PERSONNEL$(index,13)
           mapuse$ =           PERSONNEL$(index,14)

           PersData$ = Username$ + "," + Name$ + "," + Address$ + "," + Contactname$ + "," + Telephone$ + "," + Keyno$ + "," + RemoteIP$ + "," + Site.Detail1$ + "," + Site.Detail2$ + "," + Site.Detail3$ + "," + Site.Detail4$ + "," + Site.Detail5$ + "," + Opncls$ + "," + mapuse$ + ","
           FOR v.Cnt1 = 1 TO LEN(PersData$)
               PRINT "PersData$: "; PersData$
               Encrypt$ = Encrypt$ + chr$(asc(MID$(PersData$,v.Cnt1)) XOR int(rnd(1)*256))
           NEXT
           print "Encrypt: "; Encrypt$
           #persfile, Encrypt$;
           Encrypt$ = ""
       END IF
   NEXT

   CLOSE #persfile
   CALL ClearScreen
'    CLOSE #graph

   CALL EnableScreen
'END SUB
RETURN

[LoadPersonnel]

   randomize(f.SeedCode(Key$))
   OPEN currentfilename$ for BINARY as #InFile
trace 3
       FOR v.Cnt1 = 1 TO lof(#InFile)
           Decrypt$ = chr$(asc(input$(#InFile,1)) XOR int(rnd(1)*256))
           'Decrypt$ = input$(#InFile,1)
           Built$ = Built$ + Decrypt$
           'Fill array, moving one record each comma
           IF Decrypt$ = "," THEN
               Built$ = remchar$(Built$, ",")
               PERSONNEL$(a, b) = Built$
               PRINT "Built$ = "; Built$; " a = ";a;" b = ";b
               b = b + 1 : Built$ = ""
           END IF

           'We know the file structure has 14 commas so when we hit 14 we can move to the next record position otherwise we keep filling the same position
'            IF Decrypt$ = CHR$(10) THEN
           IF b = 15 THEN
               a = a + 1
               b = 1
               RecordNumber = RecordNumber + 1
           END IF
       NEXT
   CLOSE #InFile
   CALL UpdateList
RETURN

[ListShowRecord]
   #pers.list,  "selection? s.Username$"
   FOR sRecord = 0 TO RecordNumber
   #pers.info, "SEARCHING...." ;a
           IF s.Username$ =                              PERSONNEL$(sRecord, 1)                THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Name$ <> ""        AND LOWER$(s.Name$) = LOWER$(PERSONNEL$(sRecord, 2))        THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Address$ <> ""     AND LOWER$(s.Address$) = LOWER$(PERSONNEL$(sRecord, 3))     THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Contactname$ <> "" AND LOWER$(s.Contactname$) = LOWER$(PERSONNEL$(sRecord, 4)) THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Telephone$ <> ""   AND s.Telephone$ = PERSONNEL$(sRecord, 5)                   THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
           IF s.Staffno$ <> ""     AND s.Staffno$ = PERSONNEL$(sRecord, 6)                     THEN #pers.info, "Found Record " ; sRecord : SearchFound = 1 : EXIT FOR
'        END IF
   NEXT

   'If record is found, do something here. Populate fields etc
   IF SearchFound = 1 THEN

       #pers.info,"Found Record: "; sRecord
       #pers.username,   PERSONNEL$(sRecord, 1)
       #pers.contact,    PERSONNEL$(sRecord, 2)
       #pers.name,       PERSONNEL$(sRecord, 3)
       #pers.address,    PERSONNEL$(sRecord, 4)
       #pers.telephone,  PERSONNEL$(sRecord, 5)
       #pers.staffno,    PERSONNEL$(sRecord, 6)
       #pers.detail1,    PERSONNEL$(sRecord, 8)
       #pers.detail2,    PERSONNEL$(sRecord, 9)
       #pers.detail3,    PERSONNEL$(sRecord, 10)
       #pers.detail4,    PERSONNEL$(sRecord, 11)
       #pers.detail5,    PERSONNEL$(sRecord, 12)

   END IF

   PRINT "ListShowRecord. sRecord:";sRecord;" RecordNumber: "; RecordNumber

   IF SearchFound = 0 THEN #pers.info, "Complete."
WAIT

[Pers.Quit.Question]
   NOTICE WindowTitle$ + chr$(13) + "Please use the Menu to [Save all Records and Close] or [Close] without saving."
   WAIT

[Pers.quit]
   GOSUB [SavePersonnel]
   CLOSE #pers
'    UNLOADBMP "logo"
   END

[quit]
   CLOSE #pers
'    UNLOADBMP "logo"
   END

[ClearScreen]
   CALL ClearScreen
WAIT

SUB UpdateList
   FOR c = 0 TO RecordNumber
   PRINT "Update Listbox: "; PERSONNEL$(c, 1); " Total Records: "; RecordNumber
   List$(c) = PERSONNEL$(c, 1)
   NEXT
   #pers.list, "reload"
END SUB

'Remove commas
SUB CheckCommas BYREF StringName$
   'print "checking for commas!"
   StringName$ = remchar$(StringName$, ",")
END SUB

'Function to determine if a file exists
FUNCTION fileExists(path$, filename$)
   FILES path$, filename$, info$()
   fileExists = val(info$(0, 0))  'non zero is true
END FUNCTION

FUNCTION f.SeedCode(in.STG$)
   ' Uses the DLL to generate a CSC-32 hash of the input string. 'Remove commas
   v.StringLen = len(in.STG$)
   OPEN "ntdll.dll" FOR dll AS #ntdll
   CALLDLL #ntdll, "RtlComputeCrc32", 0 as long, in.STG$ as ptr, v.StringLen as long, result as long
   CLOSE #ntdll
   ' CSC-32 hash is turned into a decimal value.
   f.SeedCode = val("." + str$(abs(result)))
END FUNCTION

SUB DisableScreen
   #pers.username,     "!DISABLE"
   #pers.contact,      "!DISABLE"
   #pers.name,         "!DISABLE"
   #pers.address,      "!DISABLE"
   #pers.telephone,    "!DISABLE"
   #pers.staffno,      "!DISABLE"
   #pers.pass,         "!DISABLE"
   #pers.conf,         "!DISABLE"
   #pers.detail1,      "!DISABLE"
   #pers.detail2,      "!DISABLE"
   #pers.detail3,      "!DISABLE"
   #pers.detail4,      "!DISABLE"
   #pers.detail5,      "!DISABLE"
END SUB

SUB EnableScreen
   #pers.username,     "!ENABLE"
   #pers.contact,      "!ENABLE"
   #pers.name,         "!ENABLE"
   #pers.address,      "!ENABLE"
   #pers.telephone,    "!ENABLE"
   #pers.staffno,      "!ENABLE"
   #pers.pass,         "!ENABLE"
   #pers.conf,         "!ENABLE"
   #pers.detail1,      "!ENABLE"
   #pers.detail2,      "!ENABLE"
   #pers.detail3,      "!ENABLE"
   #pers.detail4,      "!ENABLE"
   #pers.detail5,      "!ENABLE"
END SUB

SUB ClearScreen
   #pers.username,     ""
   #pers.contact,      ""
   #pers.name,         ""
   #pers.address,      ""
   #pers.telephone,    ""
   #pers.staffno,      ""
   #pers.pass,         ""
   #pers.conf,         ""
   #pers.detail1,      ""
   #pers.detail2,      ""
   #pers.detail3,      ""
   #pers.detail4,      ""
   #pers.detail5,      ""

   Username$ = ""
   Contact$ = ""
   Name$ = ""
   Address$ = ""
   Telephone$ = ""
   Staffno$ = ""
   pass$ = ""
   conf$ = ""
   Site.Detail1$ = ""
   Site.Detail2$ = ""
   Site.Detail3$ = ""
   Site.Detail4$ = ""
   Site.Detail5$ = ""
   #pers.info, "Ready."
END SUB


So this seems to be working, I have many many tests to do but thanks all for helping. 

[Rod]

Ok, when you seed the random number generator built into Liberty basic you use the command randomise and you give it a number. We call that number a seed. That command starts the random number generator at the same point of a sequence. So the sequence of numbers will be exactly the same if you randomise then draw off numbers. That’s why it started to work because you put the randomise command back into the subs.

The hash routine that is provided takes the encrypted string and calculates a hash. You can then check that the encrypted string is untouched unaltered by calculating the hash again.

Might be overkill for your application

[Tasp]

Maybe overkill, however I have no clue how to implement that! So I'll have to leave it for now!

[Chris Iverson]

Good catch on not resetting Encrypt$, that was definitely your primary issue.

However, only fixing that would have led to a secondary issue that you fixed by moving and duplicating the RANDOMIZE() function call to the beginning of both the loading and saving routines.

And what Rod described is what your code is already doing. By making sure RANDOMIZE() gets called again, you make sure that the same sequence of bytes will come out of it.

[Tasp]

Thanks Rod, Chris and tsh. After many tests it seems to be functioning ok.