Recompiled DLL not recognized by LB

[1180michel]

Hi !

I have a problem because i want to modify a DLL (VM167.dll) with Visual Studio 2022.
The original DLL from Velleman works fine with Liberty Basic, but I want to add some features.

I'm full beginner with C++ and DLL coding... So i try first simply to recompile the original files, and the new dll is named "Essai1.dll".

Of course, I have the source codes of the DLL (to drive a Velleman I/O card VM167),
you can find those in the attached .zip file.

They are 2 problems :

1) I have to remove or rename the main.h and main.cpp wich are in the B-up directory, otherwise Visual Studio finds 2 main.h and 2 main.cpp, and he does'nt like !
2) If i do that (without changing any codes in the other files), VS compile, no errors in the Essai1.DLL, BUT BUT BUT Liberty Basic does'nt recognize this DLL ("Incorrect parameter").

Here are the comments from error.log :

Error log timestamp Monday 26/02/24 17:32:20

Runtime error: Paramètre incorrect. ( OS error 16r57 )

Error(Exception)>>defaultAction
Error(Exception)>>activateHandler: <anUndefinedObject>
Error(Exception)>>handle
Error(Exception)>>signal
Error class(Exception class)>>signal: <'Paramètre incorrect....'>
BasicProgram(Object)>>error: <'Paramètre incorrect....'>
BasicProgram>>terminateRun: <anError>
[] in BasicProgram>>errorHandlerBlock
ExceptionHandler>>evaluateResponseBlock: <aBlockClosure> for: <anError>
[] in ExceptionHandler>>handle:
ProtectedFrameMarker(BlockClosure)>>setUnwind: <aBlockClosure>
BlockClosure>>invisibleEnsure: <aBlockClosure>
ExceptionHandler>>handle: <anError>
ExceptionHandler>>findHandler: <anError>
Error(Exception)>>activateHandler: <anExceptionHandler>
Error(Exception)>>handle
Error(Exception)>>signal
Error class(Exception class)>>signal: <'Paramètre incorrect....'>
OperatingSystemInformation(Object)>>osError: <87>
OperatingSystemInformation(Object)>>osError
OperatingSystemInformation>>getErrorMessage: <193>
DynamicLinkLibrary class(Object)>>osErrorMessage: <193>
DynamicLinkLibrary class(Object)>>osError: <193>
DynamicLinkLibrary class(Object)>>osError
DynamicLinkLibrary class>>open: <'E:\Atmel\Essai1.dll'>
BasicDLL>>from: <'Essai1.dll'> mode: <'DLL'> handle: <'#dll'>
BasicDLL class(BasicFile class)>>from: <'Essai1.dll'> mode: <'DLL'> handle: <'#dll'> owner: <aBasicProgram> length: <anUndefinedObject>
[] in OpenCommand>>using:
[] in BasicProgram>>begin
ExceptionHandler>>evaluateProtectedBlock: <aBlockClosure>
[] in ExceptionHandler>>activateDuring:
ProtectedFrameMarker(BlockClosure)>>setUnwind: <aBlockClosure>
BlockClosure>>invisibleEnsure: <aBlockClosure>
ExceptionHandler>>activateDuring: <aBlockClosure>
ExceptionHandler class>>handle: <anError class> with: <aBlockClosure> during: <aBlockClosure>
BlockClosure>>on: <anError class> do: <aBlockClosure>
BasicProgram>>begin
BasicProgram>>run
[] in BasicSourcePane>>run
BasicCompiler class>>compileFromString: <' open "Essai1.dll...'> notify: <aBasicSourcePane> ifSuccess: <aBlockClosure>
BasicSourcePane>>run
BasicSourceWindow>>run
BasicEditorModel>>run: <aToolbarButton>
BasicEditorModel(Object)>>perform: <#run:> with: <aToolbarButton>
ToolbarButton>>triggerClickedEvent
Message>>perform
NotificationManager>>runPendingEvents
NotificationManager>>runEventLoop
Message>>perform
Message>>evaluate

In other words : what is to change in the source codes to get re-compiled Essai1.dll to work with Liberty basic ?

OK, it's more a problem for a Visual Studio or C++ forum, but if you can help, it should be very appreciated !

Thanks a lot !

1180michel

Attachments:

VM167.zip (291.99 KB)

[tsh73]

Any chance for 32 bit - vs - 64 bit confusion?
LB is 32 bit
Visual C very likely is 64 bit

Try to search into project settings, change "Any CPU" to "x86"
(have no idea where is it actually. It is too darn complex.)

I really suggest start simple and try to make DLL doing 2+2 for you
to prove your setup works at all.
Alas I could not locate any "create DLL" demo
May be someone has something simple?

[tsh73]

Ok I found old DLL tutorial on Internet wayback machine

So get it and make Visual Studio create simple DLL for you,
and make sure LB could work with it.

web.archive.org/web/20050305154547/http://syberden.net/libertybelle/dll.htm

[1180michel]

Thanks, tsh73 !
I had found a tutorial (in french, but exists in english) :
learn.microsoft.com/fr-fr/cpp/build/walkthrough-creating-and-using-a-dynamic-link-library-cpp?view=msvc-170
It worked, but the problem was the same.
If I change "any cpu" to "x86", the DLL is now recognized by LB, but doesn't work. So, the problem seems to be more difficult that I thought...
I will more investigate.
Thanks anyway.

[tsh73]

It worked, but the problem was the same.

Could you explain a bit more?
my guesses are
1) example worked, DLL was created, console app using this DLL runs
2) LB does not recognize DLL as is
3)

If I change "any cpu" to "x86"

- there? Please give a hint Just in case someone (or even me) wants to reproduce that.

the DLL is now recognized by LB, but doesn't work

This very example works with
unsigned long long
data type - 64 bit integer
My guess that LB defaults are for
unsigned long
32 bit integer

Try to add function that works with long or unsigned long and see if it works from LB.

[tsh73]

Ok I went through this tutorial
in Win 7, Visual Studio 2017, 32 bit
got MathLibrary.dll in Release folder
(and got client program confirming this DLL works, at least inside Visual Studio)

Then I created BAS file in that folder
Line
open "MathLibrary.dll" for dll as #myDll
works OK...

Then I added simple function in existing header
extern "C" MATHLIBRARY_API int Addit(int A, int B);
and CPP file:
int Addit(int A, int B)
{
int C;
C = A + B;
return C;
}

Now, full BAS file is
open "MathLibrary.dll" for dll as #myDll
'    open "dll1.dll" for dll as #myDll

   calldll #myDll, "Addit",_
   2 as long, _
   8 as long, _
   ret as long

   notice "From Addit Function" + chr$(13) + "2 + 8 = " + str$(ret)

close  #myDll

and it does work for me.

[Chris Iverson]

I bet the problem is decoration.

Looking at the x86 version I compiled after importing into Visual Studio, I get the following function names in the DLL:

_ClearAllDigital@4
_ClearDigitalChannel@8
_CloseDevices@0
_Connected@0
_InOutMode@12
_OpenDevices@0
_OutputAllDigital@8
_OutputAllPWM@12
_ReadAllAnalog@8
_ReadAllDigital@4
_ReadAnalogChannel@8
_ReadBackInOutMode@4
_ReadBackPWMOut@8
_ReadCounter@4
_ReadDigitalChannel@8
_ResetCounter@4
_SetAllDigital@4
_SetDigitalChannel@8
_SetPWM@16
_VersionDLL@0
_VersionFirmware@4

Those are the names you'd have to write in LB to call those functions. This is because of name decoration.

You need to add a Module Definition(.DEF) file, and tell VS to use it, to get undecorated output for STDCALL methods.

Normally, you'd have to write this yourself, with all of the functions you want to export listed. But interestingly, the ZIP file you provided actually already has one, in the existing(but unusable) 64-bit output. There's a libVM167.def file that will work just fine.

Copy the .def file over to the rest of the source files, then go into Visual Studio. Open the solution, right-click on the PROJECT in the Solution Explorer(make sure you right-click on the project, and not the solution, because we're changing build options for the project), and click "Properties" in the context menu.

In the Project Properties, expand the Linker category, and go to "Input" under Linker. There's a setting here, "Module Definition File". Click that, click "<Edit...>", and type in the name of the DEF file you have(libVM167.def, in this case.)

Click OK, then build the solution again.

EDIT: After setting a DEF file, I get the following function names in the exported DLL:

ClearAllDigital
ClearDigitalChannel
CloseDevices
Connected
InOutMode
OpenDevices
OutputAllDigital
OutputAllPWM
ReadAllAnalog
ReadAllDigital
ReadAnalogChannel
ReadBackInOutMode
ReadBackPWMOut
ReadCounter
ReadDigitalChannel
ResetCounter
SetAllDigital
SetDigitalChannel
SetPWM
VersionDLL
VersionFirmware

[1180michel]

Hello !
Thanks to you, I have today successfully compiled the "Mathlibrary" DLL with Visual Studio 2022.
The problems were coming from :
1) VS 2022 is 64 bits, so I had to set "x86" to get 32 bits DLL
2) There were 2 errors in a french translation in mathlibrary.cpp (previous vs anterieur and current vs actuel...). I get the sample in a french site...
3) The "#include vsatp.h" (or something like that) was to replace by "#include pch.h"
4) Some other little things, I don't remember...

I will now try to do the same with the VM167.dll.

Thanks anyway for your help, it was very useful !

1180michel

[1180michel]

Once more Hello !
Thanks to you both !
tsh73, You was right about "x86"
Chris, I did what You said, and all was OK ! "My" VM167.dll is now working in LB ! I began to do some change, and it works...
Good evening !
1180michel